➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Ján Stanček, Thomas Mortensson, cstratak, davin, matrixise, neologix, petr.viktorin, vstinner
Date 2018-05-22.14:02:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1526997756.71.0.682650639539.issue29640@psf.upfronthosting.co.za>
In-reply-to
Content 
> But! I suppose we could fix the bug only for platforms with PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT.

Yes, this is my proposal.

>> I propose to cast pthread_key_create() result to int, but only define PyThread_create_key() in Python/thread_pthread.h if PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is defined.

> I don't think that's a good idea. Changing API, even for platforms that aren't officially supported, sounds very harsh this late in the release cycle.

Which API change? I don't propose to modify the existing public C API "int PyThread_create_key(void)". I only propose to change it's implementation to the native pthread API when PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is defined.
History
Date User Action Args
2018-05-22 14:02:36vstinnersetrecipients: + vstinner, petr.viktorin, neologix, matrixise, davin, cstratak, Ján Stanček, Thomas Mortensson
2018-05-22 14:02:36vstinnersetmessageid: <1526997756.71.0.682650639539.issue29640@psf.upfronthosting.co.za>
2018-05-22 14:02:36vstinnerlinkissue29640 messages
2018-05-22 14:02:36vstinnercreate