Message317276
> PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is defined on most (pthread) platforms, no?
> I propose to cast pthread_key_create() result to int, but only define PyThread_create_key() in Python/thread_pthread.h if PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT is defined.
I don't think that's a good idea. Changing API, even for platforms that aren't officially supported, sounds very harsh this late in the release cycle.
But! I suppose we could fix the bug only for platforms with PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT. Other platforms would keep the current implementation -- they'd still have the bug, but the API would stay unchanged. |
|
Date |
User |
Action |
Args |
2018-05-22 13:18:02 | petr.viktorin | set | recipients:
+ petr.viktorin, vstinner, neologix, matrixise, davin, cstratak, Ján Stanček, Thomas Mortensson |
2018-05-22 13:18:02 | petr.viktorin | set | messageid: <1526995082.84.0.682650639539.issue29640@psf.upfronthosting.co.za> |
2018-05-22 13:18:02 | petr.viktorin | link | issue29640 messages |
2018-05-22 13:18:02 | petr.viktorin | create | |
|