Author barry
Recipients barry, brett.cannon, eric.snow, ncoghlan, serhiy.storchaka
Date 2018-05-16.20:01:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1526500909.35.0.682650639539.issue33537@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks, I will add an __all__

_zipimport_get_resource_reader gets called from C and it's the way we trampoline from the inscrutable zipimport.c into something we can more reasonably implement the ResourceReader API.  There's a comment above _ZipImportResourceReader but do you think that's easy to miss or misunderstand?

The use of builtins_open is historical; the importlib.resources name used to be `open`.  I think we can get rid of this cruft, as it's just an implementation detail.

I'll work on a PR
History
Date User Action Args
2018-05-16 20:01:49barrysetrecipients: + barry, brett.cannon, ncoghlan, eric.snow, serhiy.storchaka
2018-05-16 20:01:49barrysetmessageid: <1526500909.35.0.682650639539.issue33537@psf.upfronthosting.co.za>
2018-05-16 20:01:49barrylinkissue33537 messages
2018-05-16 20:01:49barrycreate