Author berker.peksag
Recipients berker.peksag, docs@python, oprypin, xdegaye
Date 2018-05-16.07:53:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1526457238.03.0.682650639539.issue32392@psf.upfronthosting.co.za>
In-reply-to
Content
I agree with Xavier's comment, but I've bitten by this before so I think it would be better if we add more common arguments to the subprocess.run() signature.

Adding **kwargs wouldn't be entirely correct since subprocess.run() doesn't pass all its arguments to subprocess.Popen().

Let's add 'env=None' to the signature of subprocess.run():

.. function:: run(args, *, stdin=None, input=None, stdout=None, stderr=None,\
                  shell=False, cwd=None, timeout=None, check=False, \
                  encoding=None, errors=None, text=None)

https://github.com/python/cpython/blob/3055c947f98a078bd10d6a8cc352048a1b771d60/Doc/library/subprocess.rst#using-the-modsubprocess-module
History
Date User Action Args
2018-05-16 07:53:58berker.peksagsetrecipients: + berker.peksag, docs@python, xdegaye, oprypin
2018-05-16 07:53:58berker.peksagsetmessageid: <1526457238.03.0.682650639539.issue32392@psf.upfronthosting.co.za>
2018-05-16 07:53:57berker.peksaglinkissue32392 messages
2018-05-16 07:53:57berker.peksagcreate