Author blakeross
Recipients
Date 2007-03-21.22:03:50
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Looks good. I skimmed briefly the tests you mentioned. The issue with test_array appears to be exactly the kind of bug this is intended to identify: it calls array.__init__(...), but array doesn't have its own initializer, so object's is used.

I'd guess that the others are failing due to whatever the problem with pickling is (test_descr uses pickling). I haven't looked into that yet.

I'm sure cooperative super calling of __init__ isn't all that common (it seems like the mechanism itself isn't used much yet, and may not be until it's done via keyword) but it doesn't seem like such a bad practice, especially when mixins are in the picture. There doesn't seem to be a great alternative.
History
Date User Action Args
2007-08-23 14:52:36adminlinkissue1683368 messages
2007-08-23 14:52:36admincreate