Author gregory.p.smith
Recipients benjamin.peterson, fweimer, gregory.p.smith, twouters
Date 2018-04-19.05:54:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1524117251.33.0.682650639539.issue33312@psf.upfronthosting.co.za>
In-reply-to
Content
I think it is worth getting such a change in.

its arguable that the compiler should be able to see through the union for this use case but I assume such a fix would only land in a recent clang version.

i'm attaching a variant on your patch that doesn't cast entire structs but just casts the VLA.

thoughts?
History
Date User Action Args
2018-04-19 05:54:11gregory.p.smithsetrecipients: + gregory.p.smith, twouters, benjamin.peterson, fweimer
2018-04-19 05:54:11gregory.p.smithsetmessageid: <1524117251.33.0.682650639539.issue33312@psf.upfronthosting.co.za>
2018-04-19 05:54:11gregory.p.smithlinkissue33312 messages
2018-04-19 05:54:10gregory.p.smithcreate