Message315473
Yeah, I've run into this before. The "correct" thing to do is use C99 VLAs. Unfortunately, that doesn't work for PyDictKeysObject because it really wants a union of VLAs but that isn't supported. The best I could do is making a struct for every possible member of the union. See the attached patch. I didn't land it because it's gross. OTOH, undefined behavior is bad, so I'm okay landing this if you don't find it too revolting. |
|
Date |
User |
Action |
Args |
2018-04-19 04:25:41 | benjamin.peterson | set | recipients:
+ benjamin.peterson, twouters, gregory.p.smith, fweimer |
2018-04-19 04:25:41 | benjamin.peterson | set | messageid: <1524111941.44.0.682650639539.issue33312@psf.upfronthosting.co.za> |
2018-04-19 04:25:41 | benjamin.peterson | link | issue33312 messages |
2018-04-19 04:25:39 | benjamin.peterson | create | |
|