Author flherne
Recipients Mark.Shannon, benjamin.peterson, flherne, georg.brandl, inada.naoki, lukasz.langa, ned.deily, rhettinger, serhiy.storchaka, vstinner
Date 2018-04-13.00:40:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1523580049.08.0.682650639539.issue32911@psf.upfronthosting.co.za>
In-reply-to
Content
Note:

Because this also applies to module-level docstrings, a rather strange effect that, for example, `ast.parse("'foo'")` is now an empty module.

While the root node is always an instance of `ast.Module`, in practice `ast.parse()` is often used with smaller fragments of source code that don't directly correspond to a complete module, and this behaviour makes no sense in such cases.

The resulting bug in kdev-python took a while to track down (because I had no immediate reason to suspect this change), and will be somewhat awkward to workaround.

I would prefer that this be reverted; it's likely to break a variety of users in strange ways.
History
Date User Action Args
2018-04-13 00:40:49flhernesetrecipients: + flherne, georg.brandl, rhettinger, vstinner, benjamin.peterson, ned.deily, inada.naoki, lukasz.langa, Mark.Shannon, serhiy.storchaka
2018-04-13 00:40:49flhernesetmessageid: <1523580049.08.0.682650639539.issue32911@psf.upfronthosting.co.za>
2018-04-13 00:40:48flhernelinkissue32911 messages
2018-04-13 00:40:47flhernecreate