Author Petter S
Recipients Petter S, asvetlov, njs, pdxjohnny, r.david.murray, yselivanov, zach.ware
Date 2018-03-12.20:22:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1520886121.97.0.467229070634.issue32972@psf.upfronthosting.co.za>
In-reply-to
Content
Personally, I think John's PR is fine. (but the test class could arguably live in asyncio) I like that setUp, tearDown and test methods all can be async.

But if setUp and tearDown should never be async as Yury commented above, they don't need runners. That is what I went for in my PR.

Introducing three new public methods to TestCase is too much. I originally made the runner private, but Yury told me to make it public and document it.
History
Date User Action Args
2018-03-12 20:22:02Petter Ssetrecipients: + Petter S, r.david.murray, njs, asvetlov, zach.ware, yselivanov, pdxjohnny
2018-03-12 20:22:01Petter Ssetmessageid: <1520886121.97.0.467229070634.issue32972@psf.upfronthosting.co.za>
2018-03-12 20:22:01Petter Slinkissue32972 messages
2018-03-12 20:22:01Petter Screate