This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author steve.dower
Recipients izbyshev, paul.moore, steve.dower, tim.golden, zach.ware
Date 2018-03-08.21:30:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1520544630.9.0.467229070634.issue33030@psf.upfronthosting.co.za>
In-reply-to
Content
> Before take_gil() knows whether it has to do any work

I thought we had a check for when the GIL was not even initialized, but that doesn't seem to exist in master any more.

Preserving GetLastError() at the same place we do errno is probably sufficient. There shouldn't be any more of a performance penalty (and maybe we don't have to preserve errno on Windows? That will save a TLS lookup at least)
History
Date User Action Args
2018-03-08 21:30:30steve.dowersetrecipients: + steve.dower, paul.moore, tim.golden, zach.ware, izbyshev
2018-03-08 21:30:30steve.dowersetmessageid: <1520544630.9.0.467229070634.issue33030@psf.upfronthosting.co.za>
2018-03-08 21:30:30steve.dowerlinkissue33030 messages
2018-03-08 21:30:30steve.dowercreate