This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eryksun
Recipients eryksun, izbyshev, paul.moore, steve.dower, tim.golden, zach.ware
Date 2018-03-06.23:20:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1520378446.62.0.467229070634.issue33016@psf.upfronthosting.co.za>
In-reply-to
Content
The inconsistent use of VOLUME_NAME_NT and VOLUME_NAME_DOS was addressed incidentally in issue 29734, but that issue is primarily about the handle leaked when GetFinalPathNameByHandleW fails. That said, you've cleanly addressed the handle leak in your PR also. I prefer the common cleanup approach that you've used here, rather than spreading the cleanup tasks around in blocks, where it can easily be overlooked.

The PR for issue 29734 also fixes some handle leaks related to win32_xstat_impl. Those leaks still need to be addressed for 3.7, and backported to 3.6.
History
Date User Action Args
2018-03-06 23:20:46eryksunsetrecipients: + eryksun, paul.moore, tim.golden, zach.ware, steve.dower, izbyshev
2018-03-06 23:20:46eryksunsetmessageid: <1520378446.62.0.467229070634.issue33016@psf.upfronthosting.co.za>
2018-03-06 23:20:46eryksunlinkissue33016 messages
2018-03-06 23:20:46eryksuncreate