Author koobs
Recipients Antoine.Brodin.FreeBSD, Arfrever, Evelyn Mitchell, djc, doko, dstufft, eric.araujo, ezio.melotti, koobs, loewis, matrixise, paul.moore, python-dev, skrah, steve.dower, thomas-petazzoni, tim.golden, vstinner, zach.ware
Date 2018-01-31.07:48:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1517384929.23.0.467229070634.issue20767@psf.upfronthosting.co.za>
In-reply-to
Content
The changeset(s) applied in this issue were/are fine (thus no response on the issue)

It is the *removal* of the changesets included in this issue (as proposed in https://github.com/python/cpython/pull/5233) that would re-break compilation of extensions with clang (requiring re-opening this issue)

The root cause of the current confusion is the special case added here was conditional on the OS ('freebsd'), whereas it should (arguably) have been for a specific compiler (clang). 

In order to do this, this leads to the compiler detection code requiring improvement, see: https://github.com/python/cpython/pull/5233#issuecomment-358906977 as it currently does not detect clang as the default compiler (cc), see: https://github.com/python/cpython/pull/5233#issuecomment-358948425
History
Date User Action Args
2018-01-31 07:48:49koobssetrecipients: + koobs, loewis, doko, paul.moore, vstinner, tim.golden, djc, ezio.melotti, eric.araujo, Arfrever, skrah, python-dev, zach.ware, steve.dower, dstufft, matrixise, thomas-petazzoni, Antoine.Brodin.FreeBSD, Evelyn Mitchell
2018-01-31 07:48:49koobssetmessageid: <1517384929.23.0.467229070634.issue20767@psf.upfronthosting.co.za>
2018-01-31 07:48:49koobslinkissue20767 messages
2018-01-31 07:48:49koobscreate