Author yselivanov
Recipients eric.snow, ncoghlan, ned.deily, steve.dower, yselivanov
Date 2018-01-30.20:30:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1517344249.96.0.467229070634.issue32604@psf.upfronthosting.co.za>
In-reply-to
Content
A couple defects reported by coverity:



** CID 1428758: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /Modules/_xxsubinterpretersmodule.c: 45 in _coerce_id()
________________________________________________________________________________________________________ *** CID 1428758: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /Modules/_xxsubinterpretersmodule.c: 45 in _coerce_id()
39 }
40 if (cid < 0) {
41 PyErr_SetString(PyExc_ValueError, 42 "'id' must be a non-negative int"); 43 return -1;
44 }
45 if (cid > INT64_MAX) {
46 PyErr_SetString(PyExc_ValueError, 47 "'id' too large (must be 64-bit int)"); 48 return -1;
49 }
50 return cid;
** CID 1428757: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /Modules/_xxsubinterpretersmodule.c: 1215 in channelid_richcompare()
________________________________________________________________________________________________________ *** CID 1428757: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /Modules/_xxsubinterpretersmodule.c: 1215 in channelid_richcompare()
1209 }
1210 int64_t othercid = PyLong_AsLongLong(other); 1211 // XXX decref other here?
1212 if (othercid == -1 && PyErr_Occurred() != NULL) { 1213 return NULL;
1214 }
1215 if (othercid < 0 || othercid > INT64_MAX) { 1216 equal = 0;
 
1217 }
1218 else {
1219 equal = (cid->id == othercid); 1220 }
** CID 1428756: Error handling issues (CHECKED_RETURN) /Modules/gcmodule.c: 1071 in gc_enable_impl()
History
Date User Action Args
2018-01-30 20:30:49yselivanovsetrecipients: + yselivanov, ncoghlan, ned.deily, eric.snow, steve.dower
2018-01-30 20:30:49yselivanovsetmessageid: <1517344249.96.0.467229070634.issue32604@psf.upfronthosting.co.za>
2018-01-30 20:30:49yselivanovlinkissue32604 messages
2018-01-30 20:30:49yselivanovcreate