This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ncoghlan
Recipients Denaun, barry, docs@python, ncoghlan
Date 2018-01-02.07:21:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1514877713.35.0.467229070634.issue32145@psf.upfronthosting.co.za>
In-reply-to
Content
As per the comment at https://bugs.python.org/issue32445#msg309356, there's a bug in my suggested changes to `ExitStack.pop_all()`: the right method to call is ExitStack.push(), *not* ExitStack.callback() (the latter adds a wrapper function to make the signatures match, but our stored callbacks all already have the right signature).

I'm not too fussy about the details of the docstring, but we need to be careful about the guarantees we make to ExitStack subclasses: if the docstring implies that "target.push()" will always be called, then we need to limit the stack stealing behaviour to actual ExitStack instances (which may be a good idea anyway).
History
Date User Action Args
2018-01-02 07:21:53ncoghlansetrecipients: + ncoghlan, barry, docs@python, Denaun
2018-01-02 07:21:53ncoghlansetmessageid: <1514877713.35.0.467229070634.issue32145@psf.upfronthosting.co.za>
2018-01-02 07:21:53ncoghlanlinkissue32145 messages
2018-01-02 07:21:52ncoghlancreate