This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author methane
Recipients methane
Date 2017-12-24.05:19:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1514092742.06.0.213398074469.issue32422@psf.upfronthosting.co.za>
In-reply-to
Content
Currently, functools.lru_cache implement own doubly-linked list.

But it is inefficient than OrderedDict because each link node is GC object.
So it may eat more memory and take longer GC time.

I added two private C API for OrderedDict and make lru_cache use it.

* _PyODict_LRUGetItem(): Similar to PyDict_GetItemWithHash() + od.move_to_end(last=True).
* _PyODict_PopItem():  Similar to odict.popitem().

Why I didn't implement C version of move_to_end() is to reduce lookup.
 _PyODict_LRUGetItem(key) lookup key once while
od[key]; od.move_to_end(key) lookup key twice.

I'll benchmark it and report result here.
History
Date User Action Args
2017-12-24 05:19:02methanesetrecipients: + methane
2017-12-24 05:19:02methanesetmessageid: <1514092742.06.0.213398074469.issue32422@psf.upfronthosting.co.za>
2017-12-24 05:19:02methanelinkissue32422 messages
2017-12-24 05:19:01methanecreate