Author mocmocamoc
Recipients fafhrd91, giampaolo.rodola, kyuupichan, mocmocamoc, yselivanov
Date 2017-12-12.17:49:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1513100988.91.0.213398074469.issue29970@psf.upfronthosting.co.za>
In-reply-to
Content
I think there's been some confusion about what PR 480 was meant to fix - it helps in cases where connections are closed during handshake, but if a server connection is waiting for a handshake but never receives any data at all then it stays in that state forever.

As for a fix, how about giving SSLProtocol a method like:

    def checkHandshakeDone(self):
        if self._in_handshake == True:
            self._abort()

and then at the end of _start_handshake() adding:

    self._loop.call_later(10, self.checkHandshakeDone)

Then if the handshake is not complete within ten seconds of starting, the connection will be aborted.
History
Date User Action Args
2017-12-12 17:49:48mocmocamocsetrecipients: + mocmocamoc, giampaolo.rodola, yselivanov, fafhrd91, kyuupichan
2017-12-12 17:49:48mocmocamocsetmessageid: <1513100988.91.0.213398074469.issue29970@psf.upfronthosting.co.za>
2017-12-12 17:49:48mocmocamoclinkissue29970 messages
2017-12-12 17:49:48mocmocamoccreate