Message 307346 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	benjamin.peterson, nirs, stutzbach, vstinner
Date	2017-11-30.22:14:56
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1512080096.08.0.213398074469.issue32186@psf.upfronthosting.co.za>
In-reply-to

Content
We already release the GIL when calling lseek() in fileio.c, in the portable_lseek() function. So it makes sense to also do it in _io_FileIO_readall_impl() in the same file. os.lseek() also releases the GIL. I found another functions which calls lseek() without releasing the GIL: * the Windows implementation of new_mmap_object() * _Py_DisplaySourceLine() * fp_setreadl() of Parser/tokenizer.c I'm not sure that these 3 functions should be modified. In case of doubt, I prefer to not touch the code.

We already release the GIL when calling lseek() in fileio.c, in the portable_lseek() function. So it makes sense to also do it in _io_FileIO_readall_impl() in the same file. os.lseek() also releases the GIL. 

I found another functions which calls lseek() without releasing the GIL:

* the Windows implementation of new_mmap_object()
* _Py_DisplaySourceLine()
* fp_setreadl() of Parser/tokenizer.c

I'm not sure that these 3 functions should be modified. In case of doubt, I prefer to not touch the code.

History
Date	User	Action	Args
2017-11-30 22:14:56	vstinner	set	recipients: + vstinner, nirs, benjamin.peterson, stutzbach
2017-11-30 22:14:56	vstinner	set	messageid: <1512080096.08.0.213398074469.issue32186@psf.upfronthosting.co.za>
2017-11-30 22:14:56	vstinner	link	issue32186 messages
2017-11-30 22:14:56	vstinner	create