Author eric.smith
Recipients amaury.forgeotdarc, atuining, berker.peksag, eric.smith, ezio.melotti, loewis, markm, paul.moore, steve.dower, tim.golden, uranusjr, zach.ware
Date 2017-11-19.15:06:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1511103998.87.0.213398074469.issue1104@psf.upfronthosting.co.za>
In-reply-to
Content
Despite the fact that as of now (or 6+ years ago!) the only way to trigger the malloc() is via VT_LPSTR, I still think the way the free() call is written is bad. What if another type is added?

If that were fixed, I still think the basic idea of this patch in isolation of the other raised issues is a good idea. If it was converted to a PR, I'd support merging it (although I'd like to hear from the Windows folks).

But it is curious that this bug is so old and it hasn't caused more problems.
History
Date User Action Args
2017-11-19 15:06:39eric.smithsetrecipients: + eric.smith, loewis, paul.moore, amaury.forgeotdarc, atuining, tim.golden, ezio.melotti, markm, berker.peksag, zach.ware, steve.dower, uranusjr
2017-11-19 15:06:38eric.smithsetmessageid: <1511103998.87.0.213398074469.issue1104@psf.upfronthosting.co.za>
2017-11-19 15:06:38eric.smithlinkissue1104 messages
2017-11-19 15:06:38eric.smithcreate