Author serhiy.storchaka
Recipients Oleg Krasnikov, serhiy.storchaka
Date 2017-11-03.13:15:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1509714942.17.0.213398074469.issue31920@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you for your patch Oleg. 3.4 and 3.5 are in security fixes only mode now.

Good catch, the usage of os.walk() in pygettext.py is incorrect. But your change is not enough. In _visit_pyfiles() the name 'CVS' is removed from the names list. If names is a list of directories emitted by os.walk(), this would exclude the whole directory CVS from searching. But if it is a new list "dirs + files", this doesn't have any effect. And directories with the ".py" extension shouldn't be added to the list of Python files. Hence _visit_pyfiles should take two separate lists for directories and files. And since it no longer is a callback, it would be better to inline its code.

There are tests for pygettext in Lib/test/test_tools/test_i18n.py. It would be nice to add a new test for the fixed feature.
History
Date User Action Args
2017-11-03 13:15:42serhiy.storchakasetrecipients: + serhiy.storchaka, Oleg Krasnikov
2017-11-03 13:15:42serhiy.storchakasetmessageid: <1509714942.17.0.213398074469.issue31920@psf.upfronthosting.co.za>
2017-11-03 13:15:42serhiy.storchakalinkissue31920 messages
2017-11-03 13:15:41serhiy.storchakacreate