Author benjamin.peterson
Recipients benjamin.peterson, christian.heimes, mgorny, vstinner
Date 2017-10-24.14:34:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1508855661.2423547.1149340208.578CA372@webmail.messagingengine.com>
In-reply-to <1508829904.18.0.213398074469.issue31834@psf.upfronthosting.co.za>
Content
On Tue, Oct 24, 2017, at 00:25, Christian Heimes wrote:
> 
> Christian Heimes <lists@cheimes.de> added the comment:
> 
> I'm pretty sure that your PR has disabled all SSE optimizations. AFAIK
> gcc does not enable SSE3 and SSE4 on X86_64 by default.
> 
> $ gcc -dM -E - < /dev/null | grep SSE
> #define __SSE2_MATH__ 1
> #define __SSE_MATH__ 1
> #define __SSE2__ 1
> #define __SSE__ 1

Before this patch, this would cause blake2b.c to use slow SSE2 only
instruction, though, right?

It seems to me this represents an improvement or the status quo in all
cases. With no extra GCC flags, the reference implementation is used
rather than a slow SSE2 implementation. If extra -m flags are in CFLAGS,
the fastest implementation for the target is used.
History
Date User Action Args
2017-10-24 14:34:25benjamin.petersonsetrecipients: + benjamin.peterson, vstinner, christian.heimes, mgorny
2017-10-24 14:34:24benjamin.petersonlinkissue31834 messages
2017-10-24 14:34:24benjamin.petersoncreate