Message 304464 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	akvadrako
Recipients	akvadrako, brett.cannon, eric.snow, ncoghlan
Date	2017-10-16.09:50:57
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1508147457.36.0.213398074469.issue31772@psf.upfronthosting.co.za>
In-reply-to

Content
That seems like it makes the most sense, though I would suggest a higher-level test, because caching of bytecode is an implementation detail. So, while mocking time.time to be constant: 1. write dummy module with x=1 2. import dummy 3. overwrite dummy module with x=2 4. reload(dummy) 5. assert dummy.x == 2 BTW Brett, I didn't think it was personal; that would be odd considering you don't know me. But from a new contributor's perspective it didn't look like you are taking bugs seriously. If you had pointed out that you will reopen it if I made a good case, that would be been more clear.

That seems like it makes the most sense, though I would suggest a higher-level test, because caching of bytecode is an implementation detail. So, while mocking time.time to be constant:

1. write dummy module with x=1
2. import dummy
3. overwrite dummy module with x=2
4. reload(dummy)
5. assert dummy.x == 2

BTW Brett, I didn't think it was personal; that would be odd considering you don't know me. But from a new contributor's perspective it didn't look like you are taking bugs seriously. If you had pointed out that you will reopen it if I made a good case, that would be been more clear.

History
Date	User	Action	Args
2017-10-16 09:50:57	akvadrako	set	recipients: + akvadrako, brett.cannon, ncoghlan, eric.snow
2017-10-16 09:50:57	akvadrako	set	messageid: <1508147457.36.0.213398074469.issue31772@psf.upfronthosting.co.za>
2017-10-16 09:50:57	akvadrako	link	issue31772 messages
2017-10-16 09:50:57	akvadrako	create