Message304049
The commit for this bug (720f0cf580e2) introduces encoding and errors arguments but doesn't actually document what the values of these should be. In the case of the encoding it could be reasonably guessed, but the only way to determine what the value of 'errors' should be is to make the logical leap and look at the TextIOWrapper doc page.
And in reply to message #274510, there certainly should be a 'text=True' argument added. There are countless use cases where text rather than bytes is the expected behaviour, and currently this has to be triggered by using a more obscure option. In any case, it could be argued that text should be returned when shell=True since this mimics the behaviour of any shell program.
(Sorry if adding a comment to a closed bug is poor etiquette; it seemed like the best place to put this comment) |
|
Date |
User |
Action |
Args |
2017-10-10 14:45:38 | andrewclegg | set | recipients:
+ andrewclegg, amaury.forgeotdarc, ncoghlan, pitrou, vstinner, mark, eric.araujo, segfaulthunter, Arfrever, r.david.murray, srid, mightyiam, chris.jerdonek, python-dev, martin.panter, eryksun, steve.dower, berwin22, davispuh |
2017-10-10 14:45:38 | andrewclegg | set | messageid: <1507646738.24.0.213398074469.issue6135@psf.upfronthosting.co.za> |
2017-10-10 14:45:38 | andrewclegg | link | issue6135 messages |
2017-10-10 14:45:38 | andrewclegg | create | |
|