Author jgehrcke
Recipients asvetlov, brandon-rhodes, christian.heimes, dstufft, giampaolo.rodola, jcea, jgehrcke, kristjan.jonsson, martius, njs, orsenthil, pitrou, vstinner
Date 2017-10-02.09:20:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1506936056.89.0.213398074469.issue16487@psf.upfronthosting.co.za>
In-reply-to
Content
Hey Antoine, Christian, Senthil!

I have invested quite a bit more time to double-check my responses to the questions asked so far, clarified where appropriate, and updated the pull request on GitHub after manually resolving the merge conflicts that accumulated over time.

I would very much appreciate to get another round of feedback. Can we somehow expedite this? I am available for pushing this further, so that maybe we can still land this in 3.7 after we missed 3.6 last year.

Based on the diff this change _appears_ to be risky but I would like to stress again that I approached this issue pretty conservatively. I tried to make this a conceptually backwards-compatible change by keeping the old code path intact (the old tests pass, too, but this is not the best criterion here).

Cheers and thanks!

Jan-Philip
History
Date User Action Args
2017-10-02 09:20:57jgehrckesetrecipients: + jgehrcke, jcea, orsenthil, pitrou, kristjan.jonsson, vstinner, giampaolo.rodola, christian.heimes, njs, asvetlov, brandon-rhodes, dstufft, martius
2017-10-02 09:20:56jgehrckesetmessageid: <1506936056.89.0.213398074469.issue16487@psf.upfronthosting.co.za>
2017-10-02 09:20:56jgehrckelinkissue16487 messages
2017-10-02 09:20:56jgehrckecreate