Author benjamin.peterson
Recipients benjamin.peterson, inada.naoki, serhiy.storchaka
Date 2017-09-07.16:36:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1504802209.1922428.1098569728.1CB0CCB5@webmail.messagingengine.com>
In-reply-to <1504772259.18.0.485843460904.issue31377@psf.upfronthosting.co.za>
Content
On Thu, Sep 7, 2017, at 01:17, INADA Naoki wrote:
> 
> INADA Naoki added the comment:
> 
> w_ref() depends on refcnt already.
> I don't think removing *_INTERN opcode makes PYC reproducible.
> https://github.com/python/cpython/blob/1f06a680de465be0c24a78ea3b610053955daa99/Python/marshal.c#L269-L271

I know—we're going to have to do something about that, too. In practice,
though, the interning behavior seems to be a bigger reproducibility
problem.

> I think "intern one string, then share it 10 times" is faster than
> "share one string 10 times, then intern each of 10 references".

We end up interning each reference individually currently.
History
Date User Action Args
2017-09-07 16:36:52benjamin.petersonsetrecipients: + benjamin.peterson, inada.naoki, serhiy.storchaka
2017-09-07 16:36:52benjamin.petersonlinkissue31377 messages
2017-09-07 16:36:52benjamin.petersoncreate