Message301592
On Thu, Sep 7, 2017, at 01:17, INADA Naoki wrote:
>
> INADA Naoki added the comment:
>
> w_ref() depends on refcnt already.
> I don't think removing *_INTERN opcode makes PYC reproducible.
> https://github.com/python/cpython/blob/1f06a680de465be0c24a78ea3b610053955daa99/Python/marshal.c#L269-L271
I know—we're going to have to do something about that, too. In practice,
though, the interning behavior seems to be a bigger reproducibility
problem.
> I think "intern one string, then share it 10 times" is faster than
> "share one string 10 times, then intern each of 10 references".
We end up interning each reference individually currently. |
|
Date |
User |
Action |
Args |
2017-09-07 16:36:52 | benjamin.peterson | set | recipients:
+ benjamin.peterson, methane, serhiy.storchaka |
2017-09-07 16:36:52 | benjamin.peterson | link | issue31377 messages |
2017-09-07 16:36:52 | benjamin.peterson | create | |
|