Author serhiy.storchaka
Recipients Oren Milman, brett.cannon, serhiy.storchaka, twouters
Date 2017-08-29.04:10:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Oren already fixed several similar problems and he is aware of difference between a crash and an exception.

The problem is Windows specific. The current code uses Unicode C API with the result of calling the replace method. This can cause a segfault (or may be an assertion failure in debug build).

The proposed solution LGTM. It undermines duck-typing, but I think this doesn't break any existing code. The duck-typing was not intentional and is Windows-only.
Date User Action Args
2017-08-29 04:10:45serhiy.storchakasetrecipients: + serhiy.storchaka, twouters, brett.cannon, Oren Milman
2017-08-29 04:10:45serhiy.storchakasetmessageid: <>
2017-08-29 04:10:45serhiy.storchakalinkissue31291 messages
2017-08-29 04:10:45serhiy.storchakacreate