Message300884
> do you still think we should backport to 2.7?
This is not trivial question. On one side, using PyString_GET_SIZE() with non-bytes object definitely is a bug. It is better to catch it earlier rather than hope on failing in the following code. On other side, adding a check for bytes can break existing user code that is passed now by accident. _PyBytes_Join() in 2.7 supports unicode objects.
I think that the fix should be backported, and the proper fix should allow bytes and unicode objects. But I left the decision on Benjamin. |
|
Date |
User |
Action |
Args |
2017-08-26 15:47:25 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, ncoghlan, benjamin.peterson, veky, Oren Milman |
2017-08-26 15:47:24 | serhiy.storchaka | set | messageid: <1503762444.97.0.641883479173.issue31271@psf.upfronthosting.co.za> |
2017-08-26 15:47:24 | serhiy.storchaka | link | issue31271 messages |
2017-08-26 15:47:24 | serhiy.storchaka | create | |
|