Author terry.reedy
Recipients csabella, louielu, ned.deily, serhiy.storchaka, terry.reedy, wohlganger
Date 2017-08-24.17:45:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1503596753.65.0.620218359161.issue27099@psf.upfronthosting.co.za>
In-reply-to
Content
The main refactoring of ConfigDialog into multiple classes is done.  Since you kept this patch up to date with the changes, I will review it next, before making further changing to individual tab pages.

On problem with implementing some features as extensions is that associated keybindings are global to all keysets, instead of being specific to one keyset.  This meant that the defaults were necessarily the same for Windows, *nix, and OSX.  (Not necessarily bad, but inflexible.)  This means that any change changes the supposedly fixed built-in keysets and that users cannot try out different bindings in different custom keysets.  This strikes me a  something of a bug, so I am looking more favorably at moving all keybindings (other than true, 3rd-party extensions) to config-keys.def/cfg.
History
Date User Action Args
2017-08-24 17:45:53terry.reedysetrecipients: + terry.reedy, ned.deily, serhiy.storchaka, louielu, csabella, wohlganger
2017-08-24 17:45:53terry.reedysetmessageid: <1503596753.65.0.620218359161.issue27099@psf.upfronthosting.co.za>
2017-08-24 17:45:53terry.reedylinkissue27099 messages
2017-08-24 17:45:53terry.reedycreate