Author haypo
Recipients haypo, inada.naoki, serhiy.storchaka, thehesiod
Date 2017-08-21.11:11:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1503313913.45.0.0348801421911.issue31095@psf.upfronthosting.co.za>
In-reply-to
Content
"like GH-2966, most types with Py_TPFLAGS_HAVE_GC should call PyObject_GC_UnTrack() at top of the tp_dealloc."

Hum, I wasn't aware of that. Writing correctly code for the Python garbage collector is very complex :-/

Maybe it would help to have a short comment, maybe with a link to this issue, on each PyObject_GC_UnTrack().

At the first read, I saw the newly added PyObject_GC_UnTrack() calls as duplicate, and so useless. For example, PyObject_Del() already untracks the object, so it doesn't seem to be needed to explicitly call PyObject_GC_UnTrack() "just before".
History
Date User Action Args
2017-08-21 11:11:53hayposetrecipients: + haypo, inada.naoki, serhiy.storchaka, thehesiod
2017-08-21 11:11:53hayposetmessageid: <1503313913.45.0.0348801421911.issue31095@psf.upfronthosting.co.za>
2017-08-21 11:11:53haypolinkissue31095 messages
2017-08-21 11:11:53haypocreate