Author terry.reedy
Recipients csabella, terry.reedy
Date 2017-07-30.21:06:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1501448811.5.0.139724869401.issue31050@psf.upfronthosting.co.za>
In-reply-to
Content
I did not refresh this before writing the above.  It still applies, including deleting the commented out code once tests pass.  See review.

Whoops: I forgot that using make_default means that we can (and should) delete the replaced var_changed defs.  I added the one for space_num back because I mistakenly thought it was needed to make the test pass.

I will open a new issue to add a comment documenting the new TabPage(Frame) class design.  The new rules will include using default var_changes when possible. Patch will include adjusting FontTab to follow the new rules.
History
Date User Action Args
2017-07-30 21:06:51terry.reedysetrecipients: + terry.reedy, csabella
2017-07-30 21:06:51terry.reedysetmessageid: <1501448811.5.0.139724869401.issue31050@psf.upfronthosting.co.za>
2017-07-30 21:06:51terry.reedylinkissue31050 messages
2017-07-30 21:06:51terry.reedycreate