Message 299283 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	terry.reedy
Recipients	cheryl.sabella, terry.reedy
Date	2017-07-27.01:30:15
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1501119015.82.0.242893696244.issue30853@psf.upfronthosting.co.za>
In-reply-to

Content
Go ahead. If it works with font, add general tab. CD.remove_var_callbacks is currently only called in test_configdialog.tearDownModule. I added the call to prevent getting a TclError for each callback after the test finished. .destroy does not destroy callbacks. I presume remove_var_callbacks was written to be called in self.cancel. Then perhaps someone discovered that there was no visible effect of deleting it, perhaps because TclErrors are caught and ignored. I want to put it, or the new equivalent, into cancel, before destroy. And make sure to add to teardownmodule.

Go ahead.  If it works with font, add general tab.

CD.remove_var_callbacks is currently only called in test_configdialog.tearDownModule.  I added the call to prevent getting a TclError for each callback after the test finished.  .destroy does not destroy callbacks.

I presume remove_var_callbacks was written to be called in self.cancel. Then perhaps someone discovered that there was no visible effect of deleting it, perhaps because TclErrors are caught and ignored.  I want to put it, or the new equivalent, into cancel, before destroy.  And make  sure to add to teardownmodule.

History
Date	User	Action	Args
2017-07-27 01:30:15	terry.reedy	set	recipients: + terry.reedy, cheryl.sabella
2017-07-27 01:30:15	terry.reedy	set	messageid: <1501119015.82.0.242893696244.issue30853@psf.upfronthosting.co.za>
2017-07-27 01:30:15	terry.reedy	link	issue30853 messages
2017-07-27 01:30:15	terry.reedy	create