Message297850
I've made the first pull request for the changes to config.py. I have to apologize because I really couldn't figure out how to do 'save_all' without including 'set_user_value' since 'set_user_value' updates userCfg with the values from ConfigChanges.
Also, in `__init__`, you had self.pages, but *self* itself is the same thing, i.e. self['main'], etc is created in the for-loop, so I couldn't figure out the difference between self and self.pages, except in the context of the Page class.
I kept the code as close to the original as possible. One side effect is that sometimes we have `self[page]` and sometimes `self[config_type]`.
I also commented out the call to `self.save_all_changed_extensions` in `save_all`. In configdialog, `save_all_changed_extensions` iterates over what would be ConfigChanges['extensions'], with the section = ext_name and item = opt. It calls `set_extension_value` with each ext_name/opt, but the difference between this and the others is that opt (item) itself is a dictionary with 'name', 'default', and 'var' keys, whereas 'main', 'keys', and 'highlight' have items with one value (at least in set_user_value).
So, if `set_user_value` stays in ConfigChanges, I believe `set_extension_value` and `save_all_changed_extensions` can be copied there as intact also. Neither one uses anything from configdialog directly, just things from ConfigChanges and idleConf.
Thanks! |
|
Date |
User |
Action |
Args |
2017-07-06 23:05:12 | cheryl.sabella | set | recipients:
+ cheryl.sabella, terry.reedy |
2017-07-06 23:05:12 | cheryl.sabella | set | messageid: <1499382312.44.0.387414727946.issue30779@psf.upfronthosting.co.za> |
2017-07-06 23:05:12 | cheryl.sabella | link | issue30779 messages |
2017-07-06 23:05:12 | cheryl.sabella | create | |
|