Message296890
Antonie:
Thank you for you comment.
Actually speaking, size of instructions are reduced on amd64@gcc.
lookdict_unicode_nodummy and lookdict_split doesn't have any reason to have duplicated code anymore. I'll do dedupe for them first.
lookdict and lookdict_unicode have one difference between code before loop and inner loop:
// before loop:
if (ix == DKIX_DUMMY) {
freeslot = i;
// inner loop:
if (ix == DKIX_DUMMY) {
if (freeslot == -1)
freeslot = i;
Since lookdict_unicode may be used for namespace, I'll keep it for now.
But lookdict() is very unlikely to be used for namespace. I'll dedupe it after checking some macro/micro benchmarks. |
|
Date |
User |
Action |
Args |
2017-06-26 13:19:50 | methane | set | recipients:
+ methane, tim.peters, rhettinger, pitrou, serhiy.storchaka, xiang.zhang, xgdomingo, Dmitry Rubanovich |
2017-06-26 13:19:50 | methane | set | messageid: <1498483190.43.0.653184629389.issue29304@psf.upfronthosting.co.za> |
2017-06-26 13:19:50 | methane | link | issue29304 messages |
2017-06-26 13:19:50 | methane | create | |
|