Author gregory.p.smith
Recipients Bernt.Røskar.Brenna, Segev Finer, eryksun, gregory.p.smith, paul.moore, sbt, steve.dower, tim.golden, vstinner, zach.ware
Date 2017-05-30.22:05:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1496181944.42.0.321603453636.issue19764@psf.upfronthosting.co.za>
In-reply-to
Content
I am not a Windows person... but is there a reason that handle_list must be an attribute of a STARTUPINFO class rather than just a special case of pass_fds such that people could supply windows handles in the pass_fds parameter rather than using STARTUPINFO?  (we can detect which is which based on type right?  or are they both integers and thus indistinguishable?)

The whole STARTUPINFO thing feels like we are exposing windows internals here and not offering an abstract API that people would write portable code to get the same behavior across OSes on without platform conditionals of their own.

But maybe that is required here given how little I know of Windows?  Food for thought.
History
Date User Action Args
2017-05-30 22:05:44gregory.p.smithsetrecipients: + gregory.p.smith, paul.moore, vstinner, tim.golden, Bernt.Røskar.Brenna, sbt, zach.ware, eryksun, steve.dower, Segev Finer
2017-05-30 22:05:44gregory.p.smithsetmessageid: <1496181944.42.0.321603453636.issue19764@psf.upfronthosting.co.za>
2017-05-30 22:05:44gregory.p.smithlinkissue19764 messages
2017-05-30 22:05:44gregory.p.smithcreate