Author serhiy.storchaka
Recipients Jim Fasarakis-Hilliard, ncoghlan, serhiy.storchaka
Date 2017-04-17.09:15:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1492420531.43.0.614339268501.issue30076@psf.upfronthosting.co.za>
In-reply-to
Content
I like the names BUILD_VAR_POSITIONAL and BUILD_VAR_KEYWORD.

The downside is that this breaks relations between them and very similar opcodes BUILD_TUPLE_UNPACK and BUILD_MAP_UNPACK. The only differences between BUILD_*_UNPACK and BUILD_*_UNPACK_WITH_CALL opcodes is that the latter takes a function name from the stack for error message and BUILD_MAP_UNPACK_WITH_CALL doesn't allow key duplications in contrary to BUILD_MAP_UNPACK. But the names BUILD_TUPLE_UNPACK and BUILD_MAP_UNPACK doesn't look very good too.
History
Date User Action Args
2017-04-17 09:15:31serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, Jim Fasarakis-Hilliard
2017-04-17 09:15:31serhiy.storchakasetmessageid: <1492420531.43.0.614339268501.issue30076@psf.upfronthosting.co.za>
2017-04-17 09:15:31serhiy.storchakalinkissue30076 messages
2017-04-17 09:15:31serhiy.storchakacreate