Author tim.peters
Recipients elliot.gorokhovsky, mdk, ppperry, serhiy.storchaka, tim.peters, vstinner
Date 2017-03-12.04:12:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1489291970.05.0.293748253475.issue28685@psf.upfronthosting.co.za>
In-reply-to
Content
Elliot, did you run the example in a release build or a debug build?  I'm wondering why this:

   assert(v->ob_type == w->ob_type &&
          v->ob_type->tp_richcompare != NULL &&
          v->ob_type->tp_richcompare == compare_funcs.key_richcompare);

didn't blow up (in `unsafe_object_compare`).

If that does blow up in a debug build, it suggests "a fix":  unconditionally check whether the tp_richcompare slot is the expected value.  If not, use `PyObject_RichCompareBool(v, w, Py_LT)` instead.
History
Date User Action Args
2017-03-12 04:12:50tim.peterssetrecipients: + tim.peters, vstinner, serhiy.storchaka, ppperry, mdk, elliot.gorokhovsky
2017-03-12 04:12:50tim.peterssetmessageid: <1489291970.05.0.293748253475.issue28685@psf.upfronthosting.co.za>
2017-03-12 04:12:50tim.peterslinkissue28685 messages
2017-03-12 04:12:49tim.peterscreate