This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Oren Milman
Recipients Oren Milman, mark.dickinson, rhettinger, serhiy.storchaka
Date 2017-03-11.22:11:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1489270313.88.0.682307986958.issue29730@psf.upfronthosting.co.za>
In-reply-to
Content
after some closer examination, ISTM that in Objects/exceptions.c, we can't
remove PyNumber_Check to optimize or simplify the code, as the argument
'filename' can be either an integer type (only in case the error is a
BlockingIOError), or quite anything else, except for None.

We could replace PyNumber_Check(filename) with PyIndex_Check(filename), but
this would change the behavior of BlockingIOError.
IMHO, this isn't that important, and thus we should leave the code in
Objects/exceptions.c as is.

anyway, I would soon create a pull request to remove all other
aforementioned calls to PyNumber_Check.
History
Date User Action Args
2017-03-11 22:11:54Oren Milmansetrecipients: + Oren Milman, rhettinger, mark.dickinson, serhiy.storchaka
2017-03-11 22:11:53Oren Milmansetmessageid: <1489270313.88.0.682307986958.issue29730@psf.upfronthosting.co.za>
2017-03-11 22:11:53Oren Milmanlinkissue29730 messages
2017-03-11 22:11:53Oren Milmancreate