Message289458
after some closer examination, ISTM that in Objects/exceptions.c, we can't
remove PyNumber_Check to optimize or simplify the code, as the argument
'filename' can be either an integer type (only in case the error is a
BlockingIOError), or quite anything else, except for None.
We could replace PyNumber_Check(filename) with PyIndex_Check(filename), but
this would change the behavior of BlockingIOError.
IMHO, this isn't that important, and thus we should leave the code in
Objects/exceptions.c as is.
anyway, I would soon create a pull request to remove all other
aforementioned calls to PyNumber_Check. |
|
Date |
User |
Action |
Args |
2017-03-11 22:11:54 | Oren Milman | set | recipients:
+ Oren Milman, rhettinger, mark.dickinson, serhiy.storchaka |
2017-03-11 22:11:53 | Oren Milman | set | messageid: <1489270313.88.0.682307986958.issue29730@psf.upfronthosting.co.za> |
2017-03-11 22:11:53 | Oren Milman | link | issue29730 messages |
2017-03-11 22:11:53 | Oren Milman | create | |
|