This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pdmccormick
Recipients Francis Deslauriers, jcea, lukasz.langa, pdmccormick
Date 2017-02-19.06:02:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1487484167.35.0.0227399067709.issue28909@psf.upfronthosting.co.za>
In-reply-to
Content
A few suggestions:

 * Disallow `--with-lttngust` on anything other than Linux (on macOS `configure` dies due to differences in acceptable `mktemp` arguments if you even attempt it)
 * Rename `cpython_inst.h` to `pytrace.h` and rename `pylttngust_probes.h` to `pytrace_lttngust_probes.h`
	- While we're at it, rename `pydtrace.h` to `pytrace_dtrace.h`, and other mentions of `PyDTrace_*` to `PyTrace_DTrace_*`?
 * Define a `WITH_TRACE` or `Py_TRACE` or similar preprocessor symbol 
 * Using that symbol, in `Python/ceval.c` ifdef-guard the static function prototypes and function calls
	- Otherwise when BOTH DTrace and LTTng-UST are disabled, Clang on macOS gives `warning: code will never be executed` warnings on the various arms of the `if (PyTraceEnabled(...))` statements, and GCC on Linux warn about unused variables `lineno`, `funcname` and `filename` in `pytrace_function_{entry,return}`, since the actual use of those variables as arguments is preprocessed out of existance

If everyone was in agreement, would it make sense to sequence this as first the generalization-renames to the existing DTrace/SystemTap code, and then recast the LTTng addition patch on top of those? I'd be happy to do this.

So, `PyTrace` or `PyTracing`?
History
Date User Action Args
2017-02-19 06:02:47pdmccormicksetrecipients: + pdmccormick, jcea, lukasz.langa, Francis Deslauriers
2017-02-19 06:02:47pdmccormicksetmessageid: <1487484167.35.0.0227399067709.issue28909@psf.upfronthosting.co.za>
2017-02-19 06:02:47pdmccormicklinkissue28909 messages
2017-02-19 06:02:46pdmccormickcreate