Message287654
I think the table of expected magic numbers will be easier to maintain than a single value, as otherwise you either have to:
- update it every time the magic number changes during the alpha/beta cycle (which would be a bad habit to encourage, since it runs counter to the purpose of the test)
- change it to None for the alpha/beta cycle (to effectively disable the test) before setting it again at the next release candidate
By contrast, the version table will typically be append only - the only time it will routinely require modification is for the first release candidate of a particular feature release, and the change will be to add a new entry for that release.
I see it as being similar to why we have the full history of all the magic numbers in _bootstrap_external.py, even though we technically only need the latest one. |
|
Date |
User |
Action |
Args |
2017-02-12 21:55:07 | ncoghlan | set | recipients:
+ ncoghlan, barry, brett.cannon, doko, petr.viktorin, eric.snow, serhiy.storchaka, Eric Appelt |
2017-02-12 21:55:07 | ncoghlan | set | messageid: <1486936507.9.0.746903002302.issue29514@psf.upfronthosting.co.za> |
2017-02-12 21:55:07 | ncoghlan | link | issue29514 messages |
2017-02-12 21:55:07 | ncoghlan | create | |
|