Message286784
Serhiy Storchaka: "We already made such changes in the past. The difference is subtle and I have
doubts that choosing any of ways was deliberate."
Right. IMHO it's safe to make sure that the buffer is contiguous. I'm quite sure that the code doesn't support non-contiguous buffers.
Serhiy Storchaka: "Please backport test changes and other changes discussed before to other branches."
Done. Sorry, I forgot this part.
Serhiy Storchaka: "unpack_buffer.patch LGTM."
Thanks for the review, it's now merged. It was a regression in unpack() docstring, Python 3.5 docstring contains "unpack(fmt, buffer)". |
|
Date |
User |
Action |
Args |
2017-02-02 13:25:50 | vstinner | set | recipients:
+ vstinner, larry, methane, python-dev, martin.panter, serhiy.storchaka |
2017-02-02 13:25:50 | vstinner | set | messageid: <1486041950.27.0.593755677851.issue29300@psf.upfronthosting.co.za> |
2017-02-02 13:25:50 | vstinner | link | issue29300 messages |
2017-02-02 13:25:50 | vstinner | create | |
|