Message285196
As for the patch itself, I would add an indentation for the second "if":
result = _levelToName.get(level)
if result is None:
result = _nameToLevel.get(level)
if result is None:
result = "Level %s" % level
return result
or even use multiple returns for the sake of microoptimization:
result = _levelToName.get(level)
if result is not None:
return result
result = _nameToLevel.get(level)
if result is not None:
return result
return "Level %s" % level
But I'm not sure that empty name is valid. It can cause problems when parse a configuration file or logs.
I don't understand the use of _nameToLevel. getLevelName('CRITICAL') returns 50, that even is not a string. |
|
Date |
User |
Action |
Args |
2017-01-11 07:25:14 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, vinay.sajip, markb, python-dev |
2017-01-11 07:25:14 | serhiy.storchaka | set | messageid: <1484119514.7.0.812214771741.issue29220@psf.upfronthosting.co.za> |
2017-01-11 07:25:14 | serhiy.storchaka | link | issue29220 messages |
2017-01-11 07:25:14 | serhiy.storchaka | create | |
|