Author serhiy.storchaka
Recipients inada.naoki, python-dev, rhettinger, serhiy.storchaka, vstinner
Date 2016-12-16.15:09:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481900944.03.0.10199351524.issue28959@psf.upfronthosting.co.za>
In-reply-to
Content
After further analysis I conclude that instance dict can be only NULL or a dict. Therefore PyDict_Size() is correctly used in typeobject.c and _datetimemodule.c. It never fails, and additional PyDict_Check() is not needed.

Committed changes don't include switching a dict structure to PyVarObject. Separate issue28988 is opened for this.

Thanks Raymond, Inada and Victor for your reviews.
History
Date User Action Args
2016-12-16 15:09:04serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, vstinner, inada.naoki, python-dev
2016-12-16 15:09:04serhiy.storchakasetmessageid: <1481900944.03.0.10199351524.issue28959@psf.upfronthosting.co.za>
2016-12-16 15:09:04serhiy.storchakalinkissue28959 messages
2016-12-16 15:09:03serhiy.storchakacreate