Message283027
> The code looks too complex.
It is if looking at the patch alone. But the skill is used across stringlib and the only thing new is the bitwise operation.
str/bytes.count is not critical but not bad if it could be optimized and especially the effect is significant for long data.
I am not favour of rejecting it now but set priority to low. |
|
Date |
User |
Action |
Args |
2016-12-12 16:49:06 | xiang.zhang | set | recipients:
+ xiang.zhang, vstinner, serhiy.storchaka |
2016-12-12 16:49:06 | xiang.zhang | set | messageid: <1481561346.89.0.745268220078.issue28921@psf.upfronthosting.co.za> |
2016-12-12 16:49:06 | xiang.zhang | link | issue28921 messages |
2016-12-12 16:49:06 | xiang.zhang | create | |
|