Author martin.panter
Recipients josh.r, larry, martin.panter, mdk, nadeem.vawda, python-dev, serhiy.storchaka, vajrasky, zach.ware
Date 2016-12-11.02:13:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481422386.68.0.245278769606.issue20185@psf.upfronthosting.co.za>
In-reply-to
Content
Zach’s comments on float seem to have been addressed (https://bugs.python.org/review/20185/diff2/10940:10949/Objects/floatobject.c). The comments on the resource module were about return converters: <http://bugs.python.org/review/20185/diff2/10817:10949/Modules/resource.c>. One has been addressed.

The other was about the rlimit2py() function, used in two places. One of these is resource.prlimit(), which is not converted to Arg Clinic in the patch. If we don’t convert it, I agree that leaving rlimit2py() as it is is simplest.

Given that the current prlimit() arg parsing is buggy (Issue 20191), it would be good to convert it to Arg Clinic in the process of solving the bug, but that could be done as a separate step.

Tangentially, the rlimit2py() function has special HAVE_LONG_LONG handling. This is no longer needed in 3.6; see Issue 27961. But again, I think it is better to review and commit the existing patch than to keep perfecting it :)
History
Date User Action Args
2016-12-11 02:13:06martin.pantersetrecipients: + martin.panter, larry, nadeem.vawda, python-dev, zach.ware, serhiy.storchaka, vajrasky, josh.r, mdk
2016-12-11 02:13:06martin.pantersetmessageid: <1481422386.68.0.245278769606.issue20185@psf.upfronthosting.co.za>
2016-12-11 02:13:06martin.panterlinkissue20185 messages
2016-12-11 02:13:05martin.pantercreate