This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients eric.smith, ncoghlan, python-dev, r.david.murray, serhiy.storchaka, vstinner
Date 2016-12-06.19:37:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <4028818.WRc9st0TEA@xarax>
In-reply-to <1481046321.85.0.862787234017.issue28838@psf.upfronthosting.co.za>
Content
> It don't think that my change makes abstract.h worse, some comments were far
> from their declaration, and there is was no unique style for comments. It's
> a mess.

Seems most of comments that did not follow common style are your comments to 
"fast call" functions. It would be better to fix only that comments.

> "That would be very large patch, and I doubt it will be approved."
> Why not?

Because it breaks "hg annotation" and makes harder researching the history of 
the file. That harms the workflow of other developers. Ask on Python-Dev before 
making such larger and questionable changes.

> You reviewed rename.patch, I only made tiny changes after this patch.

Reviewed patch did not contain committed changes. That changes are not tiny.
History
Date User Action Args
2016-12-06 19:37:13serhiy.storchakasetrecipients: + serhiy.storchaka, ncoghlan, vstinner, eric.smith, r.david.murray, python-dev
2016-12-06 19:37:13serhiy.storchakalinkissue28838 messages
2016-12-06 19:37:12serhiy.storchakacreate