Message282568
> It don't think that my change makes abstract.h worse, some comments were far
> from their declaration, and there is was no unique style for comments. It's
> a mess.
Seems most of comments that did not follow common style are your comments to
"fast call" functions. It would be better to fix only that comments.
> "That would be very large patch, and I doubt it will be approved."
> Why not?
Because it breaks "hg annotation" and makes harder researching the history of
the file. That harms the workflow of other developers. Ask on Python-Dev before
making such larger and questionable changes.
> You reviewed rename.patch, I only made tiny changes after this patch.
Reviewed patch did not contain committed changes. That changes are not tiny. |
|
Date |
User |
Action |
Args |
2016-12-06 19:37:13 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, ncoghlan, vstinner, eric.smith, r.david.murray, python-dev |
2016-12-06 19:37:13 | serhiy.storchaka | link | issue28838 messages |
2016-12-06 19:37:12 | serhiy.storchaka | create | |
|