This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Thomas.Robitaille, martin.panter, mdk, ncoghlan, ned.deily, serhiy.storchaka, vstinner
Date 2016-12-06.02:35:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
The patch looks sensible to me. The fix is basically an extension to the first fixup (9c92352324e8), where Victor split _showwarnmsg_impl() out of _showwarnmsg(). Now, _showwarnmsg() is a helper for the C module to choose between the backwards-compatible showwarning() API, and the new internal _showwarnmsg_impl() function.

I left some incidental comments on Rietveld, but they are not severe release blockers. Also, is the docstring for warnings._showwarnmsg() off? It looks like you copied it from warnings.showwarning(). Best not to suggest replacing an internal function.
Date User Action Args
2016-12-06 02:35:35martin.pantersetrecipients: + martin.panter, ncoghlan, vstinner, ned.deily, serhiy.storchaka, Thomas.Robitaille, mdk
2016-12-06 02:35:35martin.pantersetmessageid: <>
2016-12-06 02:35:35martin.panterlinkissue28835 messages
2016-12-06 02:35:34martin.pantercreate