Message282492
The patch looks sensible to me. The fix is basically an extension to the first fixup (9c92352324e8), where Victor split _showwarnmsg_impl() out of _showwarnmsg(). Now, _showwarnmsg() is a helper for the C module to choose between the backwards-compatible showwarning() API, and the new internal _showwarnmsg_impl() function.
I left some incidental comments on Rietveld, but they are not severe release blockers. Also, is the docstring for warnings._showwarnmsg() off? It looks like you copied it from warnings.showwarning(). Best not to suggest replacing an internal function. |
|
Date |
User |
Action |
Args |
2016-12-06 02:35:35 | martin.panter | set | recipients:
+ martin.panter, ncoghlan, vstinner, ned.deily, serhiy.storchaka, Thomas.Robitaille, mdk |
2016-12-06 02:35:35 | martin.panter | set | messageid: <1480991735.51.0.200683862325.issue28835@psf.upfronthosting.co.za> |
2016-12-06 02:35:35 | martin.panter | link | issue28835 messages |
2016-12-06 02:35:34 | martin.panter | create | |
|