Message 282415 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	christian.heimes
Recipients	christian.heimes, mdk, methane, tokibito
Date	2016-12-05.12:41:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1480941690.95.0.928387471199.issue28724@psf.upfronthosting.co.za>
In-reply-to

Content
Good idea! Initially I planned to add the functions and some other helpers around AF_UNIX to Python 3.6. You can directly copy the example functions from the documentation. https://docs.python.org/3/library/socket.html#socket.socket.sendmsg https://docs.python.org/3/library/socket.html#socket.socket.recvmsg Please keep the names send_fds() and recv_fds(), and pass the message like in the examples. Some protocols use the payload to signal the count of fds. Your patch is also lacking unit tests and documentation update.

Good idea! Initially I planned to add the functions and some other helpers around AF_UNIX to Python 3.6. You can directly copy the example functions from the documentation.

https://docs.python.org/3/library/socket.html#socket.socket.sendmsg
https://docs.python.org/3/library/socket.html#socket.socket.recvmsg

Please keep the names send_fds() and recv_fds(), and pass the message like in the examples. Some protocols use the payload to signal the count of fds. Your patch is also lacking unit tests and documentation update.

History
Date	User	Action	Args
2016-12-05 12:41:30	christian.heimes	set	recipients: + christian.heimes, methane, mdk, tokibito
2016-12-05 12:41:30	christian.heimes	set	messageid: <1480941690.95.0.928387471199.issue28724@psf.upfronthosting.co.za>
2016-12-05 12:41:30	christian.heimes	link	issue28724 messages
2016-12-05 12:41:30	christian.heimes	create