Author serhiy.storchaka
Recipients serhiy.storchaka, vstinner, xiang.zhang
Date 2016-11-29.08:20:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480407624.62.0.523267783682.issue28822@psf.upfronthosting.co.za>
In-reply-to
Content
I think it is nice to add tests for C API. Especially if there is no direct mapping between Python and C API ("character in str" don't call PyUnicode_FindChar()). Tests should cover all corner cases, otherwise we can miss bugs. Some C API can be not used in CPython at all, just in third-party extensions, and special tests is the only way to test them. The implementation of PyUnicode_FindChar() is not so simple (for example see issue24821).

I don't have an opinion about supporting negative indices.
History
Date User Action Args
2016-11-29 08:20:24serhiy.storchakasetrecipients: + serhiy.storchaka, vstinner, xiang.zhang
2016-11-29 08:20:24serhiy.storchakasetmessageid: <1480407624.62.0.523267783682.issue28822@psf.upfronthosting.co.za>
2016-11-29 08:20:24serhiy.storchakalinkissue28822 messages
2016-11-29 08:20:24serhiy.storchakacreate