This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author davin
Recipients davin, pitrou, sbt
Date 2016-11-29.05:21:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480396861.88.0.960992647071.issue28779@psf.upfronthosting.co.za>
In-reply-to
Content
I don't see any negative consequences for the helpers if the `force=True` is made in spawn.prepare's invocation of set_start_method().  In tracing backwards to figure out why this wasn't done already, it seems unchanged since sbt's patch in issue18999.


This change may impact users of execution-bundling tools like cx-freeze -- issue22255 suggests this could make freezing things easier for some.  I admit I don't fully appreciate the details of how these tools are implemented.


> (that said, if you think this is out of scope for this issue, I can revert that part of the patch)

Given the nature of BaseContext's implementation, I don't see a problem with keeping your change.  In case I was missing something, I spent some time searching for code possibly depending upon BaseContext.set_start_method's calling arguments but turned up nothing (no surprises).  It feels cleaner to update it to be in sync with DefaultContext.


Overall, LGTM the way you have it.
History
Date User Action Args
2016-11-29 05:21:01davinsetrecipients: + davin, pitrou, sbt
2016-11-29 05:21:01davinsetmessageid: <1480396861.88.0.960992647071.issue28779@psf.upfronthosting.co.za>
2016-11-29 05:21:01davinlinkissue28779 messages
2016-11-29 05:21:01davincreate