Author Tim.Graham
Recipients Carl Ekerot, Tim.Graham, christian.heimes, loewis, python-dev, serhiy.storchaka, xiang.zhang
Date 2016-11-14.16:23:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1479140588.18.0.730604068015.issue28563@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks, that does fix that first test. There is one more that still fails:

$ python -Wall tests/runtests.py humanize_tests.tests.HumanizeTests.test_i18n_intword
Testing against Django installed in '/home/tim/code/django/django' with up to 3 processes
Creating test database for alias 'default'...
Creating test database for alias 'other'...
/home/tim/code/cpython/Lib/gettext.py:454: DeprecationWarning: Plural value must be an integer, got 1.2
  tmsg = self._catalog[(msgid1, self.plural(n))]
/home/tim/code/cpython/Lib/gettext.py:454: DeprecationWarning: Plural value must be an integer, got 1.2
  tmsg = self._catalog[(msgid1, self.plural(n))]
F
======================================================================
FAIL: test_i18n_intword (humanize_tests.tests.HumanizeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tim/code/django/tests/humanize_tests/tests.py", line 133, in test_i18n_intword
    self.humanize_tester(test_list, result_list, 'intword')
  File "/home/tim/code/django/tests/humanize_tests/tests.py", line 39, in humanize_tester
    msg="%s test failed, produced '%s', should've produced '%s'" % (method, rendered, result))
AssertionError: '1,2 Million' != '1,2 Millionen' : intword test failed, produced '1,2 Million', should've produced '1,2 Millionen'

I think the relevant code is https://github.com/django/django/blob/cbae4d31847d75d889815bfe7c04af035f45e28d/django/contrib/humanize/templatetags/humanize.py#L60-L63. I'm not too familiar with this code, but I'll try to get a better explanation if it's not clear to you.
History
Date User Action Args
2016-11-14 16:23:08Tim.Grahamsetrecipients: + Tim.Graham, loewis, christian.heimes, python-dev, serhiy.storchaka, xiang.zhang, Carl Ekerot
2016-11-14 16:23:08Tim.Grahamsetmessageid: <1479140588.18.0.730604068015.issue28563@psf.upfronthosting.co.za>
2016-11-14 16:23:08Tim.Grahamlinkissue28563 messages
2016-11-14 16:23:07Tim.Grahamcreate