Author berker.peksag
Recipients Dimitri Merejkowsky, berker.peksag
Date 2016-11-07.20:49:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1478551776.07.0.306260095829.issue28559@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch, but I find your proposed message less clearer (including NoneType adds unnecessary confusion and people may ask "where did NoneType come from?")

Python 2 is different because of historical reasons (pre-BaseException era) so I don't think we should look at it in this case.

If other core developers give their +1s, the patch needs to be updated to add a test case (it can be added to Lib/test/test_exceptions.py) and use the Py_TYPE() macro instead of accessing exc->ob_type directly.
History
Date User Action Args
2016-11-07 20:49:36berker.peksagsetrecipients: + berker.peksag, Dimitri Merejkowsky
2016-11-07 20:49:36berker.peksagsetmessageid: <1478551776.07.0.306260095829.issue28559@psf.upfronthosting.co.za>
2016-11-07 20:49:36berker.peksaglinkissue28559 messages
2016-11-07 20:49:35berker.peksagcreate