Message280238
Thanks for the patch, but I find your proposed message less clearer (including NoneType adds unnecessary confusion and people may ask "where did NoneType come from?")
Python 2 is different because of historical reasons (pre-BaseException era) so I don't think we should look at it in this case.
If other core developers give their +1s, the patch needs to be updated to add a test case (it can be added to Lib/test/test_exceptions.py) and use the Py_TYPE() macro instead of accessing exc->ob_type directly. |
|
Date |
User |
Action |
Args |
2016-11-07 20:49:36 | berker.peksag | set | recipients:
+ berker.peksag, Dimitri Merejkowsky |
2016-11-07 20:49:36 | berker.peksag | set | messageid: <1478551776.07.0.306260095829.issue28559@psf.upfronthosting.co.za> |
2016-11-07 20:49:36 | berker.peksag | link | issue28559 messages |
2016-11-07 20:49:35 | berker.peksag | create | |
|